review(AR): update holidays against official sources#616
Merged
Conversation
Because Ley 24.445 changes the commemorative wording in 1995, the June 20 entries now use period-specific names.
Replace outdated interior/mininterior source links with current stable official Argentina holiday pages.
Owner
|
Many thanks. |
Contributor
Author
|
I have you to thank! There is still a long way to finishing the migration of opening_hours.js to date-holidays, but comparing the data in advance is already helping to improve the data on both our sites. I’m so excited about open source 😃 |
Owner
|
Your help and efforts are really appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While comparing the holiday data in opening_hours.js and
date-holidaysfor Argentina, I noticed a few differences. I checked them against official sources and updated the data accordingly in this PR.See commit messages for more details.